Not define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT for Clang#2024
Not define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT for Clang#2024fujunwei wants to merge 1 commit intouxlfoundation:masterfrom
Conversation
|
@fujunwei, could you please rebase your branch from master to ensure all the checks pass? Thanks in advance! |
|
I notice your change also fail on the copyright check. After some struggle I figured out that this check expect a line like "Copyright (c) 2026 UXL Foundation Contributors" in the headers where it claim there is missing copyright information. |
fujunwei
force-pushed
the
build_openvino_with_chromium
branch
from
4ada617 to
494ac34
Compare
|
Rebased the latest code, PTAL. Thanks. |
|
/cc @huningxin |
|
@dnmokhov @petterreinholdtsen could you please take a look again, thanks. |
| __TBB_GLIBCXX_VERSION >= 90000 && __TBB_LANG >= 201703L) | ||
| #define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT (_MSC_VER >= 1911) | ||
| #define __TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENT (_MSC_VER >= 1911 && !__clang__) |
There was a problem hiding this comment.
This has an undesirable effect of disabling std::hardware_destructive_interference_size for ICX (which is Clang-based). Have you considered using something like __has_feature instead?
|
I just ran into this issue. |
4 participants
We are trying to build OpenVINO with Chromiumt, but the
__TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENTis only defined for MSVC (_MSC_VER >= 1911), the Clang (used in Chromium builds) doesn't supportstd::hardware_destructive_interference_sizethat is not available in Clang's standard library, so adds&& !__clang__to the__TBB_CPP17_HW_INTERFERENCE_SIZE_PRESENTmacro.