Skip to content

refactor(skills): align meta skills with style guide#11087

Draft
Alan-TheGentleman wants to merge 1 commit intofeat/skill-style-guide-refactorfrom
refactor/skill-style-meta-foundation
Draft

refactor(skills): align meta skills with style guide#11087
Alan-TheGentleman wants to merge 1 commit intofeat/skill-style-guide-refactorfrom
refactor/skill-style-meta-foundation

Conversation

@Alan-TheGentleman
Copy link
Copy Markdown
Contributor

@Alan-TheGentleman Alan-TheGentleman commented May 8, 2026

Context

This is PR 1 of a chained feature-branch refactor to standardize repository skills around a clearer runtime format.

This batch establishes the base contract for skills: trigger-first descriptions, fixed section order, explicit decision gates, and explicit output expectations.

Description

  • Refactors skills/skill-creator/SKILL.md into the new runtime-contract structure
  • Refactors skills/skill-sync/SKILL.md around explicit sync decisions and output requirements
  • Keeps the batch focused on the meta-skills that shape how future skills are created and synchronized

Chain Context

  • Strategy: feature-branch-chain
  • Tracker branch: feat/skill-style-guide-refactor
  • Current PR: 1 / 4 📍
  • Base branch: feat/skill-style-guide-refactor
  • Next planned PR: refactor/skill-style-core-generic
feat/skill-style-guide-refactor
└── refactor/skill-style-meta-foundation 📍
    └── refactor/skill-style-core-generic
        └── refactor/skill-style-core-prowler
            └── refactor/skill-style-specialists

Out of scope for this PR:

  • Generic core skills (tdd, react-19, typescript, tailwind-4, vitest, pytest)
  • Prowler workflow skills (prowler, prowler-api, prowler-ui, jsonapi, django-drf)
  • Oversized specialist skills (prowler-compliance, django-migration-psql, postgresql-indexing, prowler-attack-paths-query)

Steps to review

  1. Review skills/skill-creator/SKILL.md
    • Confirm the frontmatter description is one quoted line with Trigger: first
    • Confirm the body follows: Activation Contract → Hard Rules → Decision Gates → Execution Steps → Output Contract → References
  2. Review skills/skill-sync/SKILL.md
    • Confirm sync/no-op behavior is expressed through explicit decision gates
    • Confirm references are local-only and point to repo files
  3. Verify the batch stayed review-sized and limited to the two meta-skills

Validation performed:

  • Structural RED/GREEN validation for required sections and one-line trigger-first descriptions
  • skill-sync workflow intentionally skipped because metadata.scope and metadata.auto_invoke did not change

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- reshape skill-creator into the runtime contract format
- refactor skill-sync around explicit sync decision gates
- replace handbook prose with compact local-first references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant