feat(ui): ASD Essential Eight compliance framework support#11071
Open
feat(ui): ASD Essential Eight compliance framework support#11071
Conversation
Contributor
|
✅ All necessary |
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
2 package(s) affected
|
alejandrobailo
requested changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Nice work!, some changes:
- Rebase onto master please.
- Review the CHANGELOG.
Important
- Replace string-grep tests in asd-essential-eight.test.ts and compliance-mapper.test.ts with behavioral tests
(extract pure mapper or vi.mock server-only deps). - Add tests for asd-essential-eight-details.tsx, render with full and empty requirement props.
- Remove as string casts in details component; narrow types with typeof x === "string" guards.
- Broaden References regex to /https?://[^\s,]+/g so http:// URLs aren't silently dropped.
Minor
- Add a TODO with ticket ID next to the unused _filter parameter.
- Remove || [] and ?? "Uncategorized" fallbacks if the types declare the fields as required, or fix the types.
- Rename aws_description → implementation_notes (or provider_description) to avoid AWS-only coupling on a generic
Requirement type. - Consider COMPLIANCE_LOGOS as a tuple array instead of an object literal to make ordering explicit.
a61bd04 to
8855850
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ASD Essential Eight compliance framework support for the UI.
Screen.Recording.2026-05-06.at.17.21.10.mov
Checklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.