Skip to content

feat(ui): ASD Essential Eight compliance framework support#11071

Open
pedrooot wants to merge 4 commits intomasterfrom
PROWLER-1470-add-asd-essential-eight-compliance-framework-support-ui
Open

feat(ui): ASD Essential Eight compliance framework support#11071
pedrooot wants to merge 4 commits intomasterfrom
PROWLER-1470-add-asd-essential-eight-compliance-framework-support-ui

Conversation

@pedrooot
Copy link
Copy Markdown
Member

@pedrooot pedrooot commented May 6, 2026

Description

This PR adds the ASD Essential Eight compliance framework support for the UI.

Screen.Recording.2026-05-06.at.17.21.10.mov

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? Yes / No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested a review from a team as a code owner May 6, 2026 16:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔒 Container Security Scan

Image: prowler-ui:bc998ce
Last scan: 2026-05-08 12:38:54 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

Copy link
Copy Markdown
Contributor

@alejandrobailo alejandrobailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!, some changes:

  1. Rebase onto master please.
  2. Review the CHANGELOG.

Important

  1. Replace string-grep tests in asd-essential-eight.test.ts and compliance-mapper.test.ts with behavioral tests
    (extract pure mapper or vi.mock server-only deps).
  2. Add tests for asd-essential-eight-details.tsx, render with full and empty requirement props.
  3. Remove as string casts in details component; narrow types with typeof x === "string" guards.
  4. Broaden References regex to /https?://[^\s,]+/g so http:// URLs aren't silently dropped.

Minor

  1. Add a TODO with ticket ID next to the unused _filter parameter.
  2. Remove || [] and ?? "Uncategorized" fallbacks if the types declare the fields as required, or fix the types.
  3. Rename aws_description → implementation_notes (or provider_description) to avoid AWS-only coupling on a generic
    Requirement type.
  4. Consider COMPLIANCE_LOGOS as a tuple array instead of an object literal to make ordering explicit.

@pedrooot pedrooot force-pushed the PROWLER-1470-add-asd-essential-eight-compliance-framework-support-ui branch from a61bd04 to 8855850 Compare May 8, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants