Fix ISB001 misfires on proxy fields that are disposed#428
Open
Fix ISB001 misfires on proxy fields that are disposed#428
Conversation
…gned to a field When GetProxyAsync or new ServiceBrokerClient is inside a lambda that is assigned to a field (e.g., AsyncLazy<ServiceBrokerClient>), FindAncestors incorrectly crossed the anonymous function boundary and attributed the proxy to the outer field. This caused ISB001 to require disposal of a field that doesn't directly hold a proxy. The fix prevents EnsureAssignedValueIsDisposed from crossing anonymous function (lambda) or local function boundaries when looking for ancestor assignments. Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ISB001 misfire on disposed proxy fields
Fix ISB001 misfires when proxy is created inside a lambda assigned to a field
Feb 24, 2026
Member
|
@copilot Where did this lambdas handling change come from? The issue you were supposed to fix mentioned nothing about lambdas. It was about Dispose methods that were Please start from scratch and focus on the problem identified by the issue. |
…isons Replace ImmutableArray<T>.Contains() calls (which use default reference equality) with SymbolEqualityComparer.Default.Equals() for three critical symbol comparisons: 1. AllInterfaces.Contains(idisposable) - controls whether Dispose methods are analyzed for the type (affects override Dispose(bool) recognition) 2. getProxyAsyncMethods.Contains(...) - identifies GetProxyAsync calls 3. ExplicitInterfaceImplementations.Contains(disposeMethod) - recognizes explicit IDisposable.Dispose() implementations Also adds two new tests for override Dispose(bool) with base class and explicit interface IDisposable.Dispose() with cast-based disposal. Co-authored-by: AArnott <3548+AArnott@users.noreply.github.com>
Author
Reverted the lambda changes and started from scratch. The root cause is that three
Fixed all three to use Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Fix ISB001 misfires when proxy is created inside a lambda assigned to a field
Fix ISB001 misfires on proxy fields that are disposed
Feb 24, 2026
AArnott
approved these changes
Feb 24, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISB001 false-positives when proxy fields are properly disposed in
override Dispose(bool)methods or explicitIDisposable.Dispose()implementations.The root cause is that three
ImmutableArray<T>.Contains()calls used default reference equality instead ofSymbolEqualityComparerto compare Roslyn symbols, which can fail to match symbols in complex compilation environments (e.g., VS extensions with many assembly references):AllInterfaces.Contains(idisposable)— controls whether Dispose methods are analyzed for the type. If this comparison fails,AnalyzeDisposeMethodsis never registered, so no Dispose method (includingoverride Dispose(bool)) is analyzed.getProxyAsyncMethods.Contains(...)— identifiesGetProxyAsynccalls.ExplicitInterfaceImplementations.Contains(disposeMethod)— recognizes explicitIDisposable.Dispose()implementations.Changes
AllInterfaces.Contains(idisposable)→AllInterfaces.Any(i => SymbolEqualityComparer.Default.Equals(i, idisposable))— ensures Dispose method analysis is registered even whenIDisposableis inherited from a base typegetProxyAsyncMethods.Contains(...)→ usesSymbolEqualityComparer.Default.Equals()— consistent symbol comparison forGetProxyAsyncidentificationExplicitInterfaceImplementations.Contains(disposeMethod)→ usesSymbolEqualityComparer.Default.Equals()— ensures explicitIDisposable.Dispose()implementations are recognizedoverride Dispose(bool)with base class providingIDisposable, and explicitIDisposable.Dispose()with cast-based disposal patternOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.