Skip to content

docs(redact/server): correct fallback wire-format comment — fallback '<div>' is visible, not hidden #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sukvvon wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

docs(redact/server): correct fallback wire-format comment — fallback '<div>' is visible, not hidden #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/redact/src/server/bootstrap-script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@
* main bundle can replay them against un-hydrated subtrees ($RE_q buffer).
*
* Wire format:
* Fallback: <!--$?ID--><div hidden id="B:ID">fallback</div><!--/$-->
* Fallback: <!--$?ID--><div id="B:ID">fallback</div><!--/$-->
* Resolved: emits <div hidden id="S:ID">real</div><script>$RC(ID)</script>
* which splices real into place and rewrites the comment to <!--$ID-->.
* The fallback div is visible (it's the user-visible loading
* state); only the resolved-content staging div is `hidden`
* before $RC moves its children inline.
*
* Client hydration calls $RH(ID, cb) to register a callback invoked once the
* boundary has been revealed (or immediately, if it was already revealed).
Expand Down