Project document head elements#10
Draft
southpolesteve wants to merge 1 commit intoTanStack:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<head>when rendering an<html>tree with no head child.<head>when hydrating a Document root.document.headduring hydration and insert new document-level head tags intodocument.head.<head>and top-level metadata.Why
vinext follows Next/App Router document semantics where metadata can be represented as top-level head elements around the html shell. Browsers only allow one document element and head-managed tags must live in
document.head. Without this, Redact can try to append<meta>directly todocumentduring hydration, causingOnly one element on document allowed, or fail to match server-rendered metadata.This makes Redact compatible with vinext App Router SSR/hydration while keeping existing
<head>/<html>adoption position-insensitive.Validation
pnpm --filter tests test -- document-hydration