refactor: show finding in problems panel on single line#132
Open
refactor: show finding in problems panel on single line#132
Conversation
This commit shortens the result of a ggshield scan to one line per finding. This is more in line with VSCode conventions with regards to the problem view. The full finding data remains visible through the hover window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, we display a detailed, multi-line message for each secret we find in VSCode's Problems View. The Problems View lists all issues raised from installed extensions by file. By convention, the individual problem message should spawn only one line.
What has been done
This PR shortens the result of a
ggshieldscan to one line per finding. The full finding data remains visible through the hover window.Validation
ggshieldPR check list