feat: forward cluster-autoscaler and capi provider logs to shoebox#5161
feat: forward cluster-autoscaler and capi provider logs to shoebox#5161ashishmax31 wants to merge 1 commit intomainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashishmax31 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| Alias filter.shoebox_router | ||
| Match ocm.logs | ||
| Rule $kubernetes['container_name'] ^(audit-logs|kube-apiserver|kube-controller-manager|kube-scheduler|cloud-controller-manager|csi-driver|snapshot-controller)$ shoeboxlogs true | ||
| Rule $kubernetes['container_name'] ^(audit-logs|kube-apiserver|kube-controller-manager|kube-scheduler|cloud-controller-manager|csi-driver|snapshot-controller|manager|cluster-autoscaler)$ shoeboxlogs true |
There was a problem hiding this comment.
The capi provider pods's main container is called "manager" which is very generic. But i have added a check to check the pod name to match "capi-provider" so that we don't send logs from arbitrary containers with name "manager".
There was a problem hiding this comment.
Pull request overview
Adds Shoebox forwarding support for additional control plane log categories emitted in ocm-* namespaces, specifically cluster-autoscaler and CAPI provider logs, by expanding Fluent Bit routing and Shoebox transformation logic.
Changes:
- Extend the Shoebox routing rule to include
cluster-autoscalerandmanager(for CAPI provider) container logs. - Add Shoebox category mapping for
cluster-autoscalerand infercapi-providercategory based onmanagercontainer +capi-provider*pod name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sample logs from testing: |
Signed-off-by: Ashish <asnaraya@redhat.com>
9847c88 to
b4c12fc
Compare
|
/hold |
|
Do not merge until the shoebox manifest is updated. |
https://redhat.atlassian.net/browse/ARO-26491
What
This PR allows us to forward two new log categories to from the ocm namespace, capi provider and cluster autoscaler to shoebox.
Why
Customer request.
Testing
Tested in personal dev env. Emitted logs in the comments.
[] Need to update the shoebox manifest(with the new manifest) in all regions before we can promote this to stage or prod.